0001 .. SPDX-License-Identifier: GPL-2.0
0002
0003 =================================
0004 Open Firmware Devicetree Unittest
0005 =================================
0006
0007 Author: Gaurav Minocha <gaurav.minocha.os@gmail.com>
0008
0009 1. Introduction
0010 ===============
0011
0012 This document explains how the test data required for executing OF unittest
0013 is attached to the live tree dynamically, independent of the machine's
0014 architecture.
0015
0016 It is recommended to read the following documents before moving ahead.
0017
0018 (1) Documentation/devicetree/usage-model.rst
0019 (2) http://www.devicetree.org/Device_Tree_Usage
0020
0021 OF Selftest has been designed to test the interface (include/linux/of.h)
0022 provided to device driver developers to fetch the device information..etc.
0023 from the unflattened device tree data structure. This interface is used by
0024 most of the device drivers in various use cases.
0025
0026
0027 2. Verbose Output (EXPECT)
0028 ==========================
0029
0030 If unittest detects a problem it will print a warning or error message to
0031 the console. Unittest also triggers warning and error messages from other
0032 kernel code as a result of intentionally bad unittest data. This has led
0033 to confusion as to whether the triggered messages are an expected result
0034 of a test or whether there is a real problem that is independent of unittest.
0035
0036 'EXPECT \ : text' (begin) and 'EXPECT / : text' (end) messages have been
0037 added to unittest to report that a warning or error is expected. The
0038 begin is printed before triggering the warning or error, and the end is
0039 printed after triggering the warning or error.
0040
0041 The EXPECT messages result in very noisy console messages that are difficult
0042 to read. The script scripts/dtc/of_unittest_expect was created to filter
0043 this verbosity and highlight mismatches between triggered warnings and
0044 errors vs expected warnings and errors. More information is available
0045 from 'scripts/dtc/of_unittest_expect --help'.
0046
0047
0048 3. Test-data
0049 ============
0050
0051 The Device Tree Source file (drivers/of/unittest-data/testcases.dts) contains
0052 the test data required for executing the unit tests automated in
0053 drivers/of/unittest.c. Currently, following Device Tree Source Include files
0054 (.dtsi) are included in testcases.dts::
0055
0056 drivers/of/unittest-data/tests-interrupts.dtsi
0057 drivers/of/unittest-data/tests-platform.dtsi
0058 drivers/of/unittest-data/tests-phandle.dtsi
0059 drivers/of/unittest-data/tests-match.dtsi
0060
0061 When the kernel is build with OF_SELFTEST enabled, then the following make
0062 rule::
0063
0064 $(obj)/%.dtb: $(src)/%.dts FORCE
0065 $(call if_changed_dep, dtc)
0066
0067 is used to compile the DT source file (testcases.dts) into a binary blob
0068 (testcases.dtb), also referred as flattened DT.
0069
0070 After that, using the following rule the binary blob above is wrapped as an
0071 assembly file (testcases.dtb.S)::
0072
0073 $(obj)/%.dtb.S: $(obj)/%.dtb
0074 $(call cmd, dt_S_dtb)
0075
0076 The assembly file is compiled into an object file (testcases.dtb.o), and is
0077 linked into the kernel image.
0078
0079
0080 3.1. Adding the test data
0081 -------------------------
0082
0083 Un-flattened device tree structure:
0084
0085 Un-flattened device tree consists of connected device_node(s) in form of a tree
0086 structure described below::
0087
0088 // following struct members are used to construct the tree
0089 struct device_node {
0090 ...
0091 struct device_node *parent;
0092 struct device_node *child;
0093 struct device_node *sibling;
0094 ...
0095 };
0096
0097 Figure 1, describes a generic structure of machine's un-flattened device tree
0098 considering only child and sibling pointers. There exists another pointer,
0099 ``*parent``, that is used to traverse the tree in the reverse direction. So, at
0100 a particular level the child node and all the sibling nodes will have a parent
0101 pointer pointing to a common node (e.g. child1, sibling2, sibling3, sibling4's
0102 parent points to root node)::
0103
0104 root ('/')
0105 |
0106 child1 -> sibling2 -> sibling3 -> sibling4 -> null
0107 | | | |
0108 | | | null
0109 | | |
0110 | | child31 -> sibling32 -> null
0111 | | | |
0112 | | null null
0113 | |
0114 | child21 -> sibling22 -> sibling23 -> null
0115 | | | |
0116 | null null null
0117 |
0118 child11 -> sibling12 -> sibling13 -> sibling14 -> null
0119 | | | |
0120 | | | null
0121 | | |
0122 null null child131 -> null
0123 |
0124 null
0125
0126 Figure 1: Generic structure of un-flattened device tree
0127
0128
0129 Before executing OF unittest, it is required to attach the test data to
0130 machine's device tree (if present). So, when selftest_data_add() is called,
0131 at first it reads the flattened device tree data linked into the kernel image
0132 via the following kernel symbols::
0133
0134 __dtb_testcases_begin - address marking the start of test data blob
0135 __dtb_testcases_end - address marking the end of test data blob
0136
0137 Secondly, it calls of_fdt_unflatten_tree() to unflatten the flattened
0138 blob. And finally, if the machine's device tree (i.e live tree) is present,
0139 then it attaches the unflattened test data tree to the live tree, else it
0140 attaches itself as a live device tree.
0141
0142 attach_node_and_children() uses of_attach_node() to attach the nodes into the
0143 live tree as explained below. To explain the same, the test data tree described
0144 in Figure 2 is attached to the live tree described in Figure 1::
0145
0146 root ('/')
0147 |
0148 testcase-data
0149 |
0150 test-child0 -> test-sibling1 -> test-sibling2 -> test-sibling3 -> null
0151 | | | |
0152 test-child01 null null null
0153
0154
0155 Figure 2: Example test data tree to be attached to live tree.
0156
0157 According to the scenario above, the live tree is already present so it isn't
0158 required to attach the root('/') node. All other nodes are attached by calling
0159 of_attach_node() on each node.
0160
0161 In the function of_attach_node(), the new node is attached as the child of the
0162 given parent in live tree. But, if parent already has a child then the new node
0163 replaces the current child and turns it into its sibling. So, when the testcase
0164 data node is attached to the live tree above (Figure 1), the final structure is
0165 as shown in Figure 3::
0166
0167 root ('/')
0168 |
0169 testcase-data -> child1 -> sibling2 -> sibling3 -> sibling4 -> null
0170 | | | | |
0171 (...) | | | null
0172 | | child31 -> sibling32 -> null
0173 | | | |
0174 | | null null
0175 | |
0176 | child21 -> sibling22 -> sibling23 -> null
0177 | | | |
0178 | null null null
0179 |
0180 child11 -> sibling12 -> sibling13 -> sibling14 -> null
0181 | | | |
0182 null null | null
0183 |
0184 child131 -> null
0185 |
0186 null
0187 -----------------------------------------------------------------------
0188
0189 root ('/')
0190 |
0191 testcase-data -> child1 -> sibling2 -> sibling3 -> sibling4 -> null
0192 | | | | |
0193 | (...) (...) (...) null
0194 |
0195 test-sibling3 -> test-sibling2 -> test-sibling1 -> test-child0 -> null
0196 | | | |
0197 null null null test-child01
0198
0199
0200 Figure 3: Live device tree structure after attaching the testcase-data.
0201
0202
0203 Astute readers would have noticed that test-child0 node becomes the last
0204 sibling compared to the earlier structure (Figure 2). After attaching first
0205 test-child0 the test-sibling1 is attached that pushes the child node
0206 (i.e. test-child0) to become a sibling and makes itself a child node,
0207 as mentioned above.
0208
0209 If a duplicate node is found (i.e. if a node with same full_name property is
0210 already present in the live tree), then the node isn't attached rather its
0211 properties are updated to the live tree's node by calling the function
0212 update_node_properties().
0213
0214
0215 3.2. Removing the test data
0216 ---------------------------
0217
0218 Once the test case execution is complete, selftest_data_remove is called in
0219 order to remove the device nodes attached initially (first the leaf nodes are
0220 detached and then moving up the parent nodes are removed, and eventually the
0221 whole tree). selftest_data_remove() calls detach_node_and_children() that uses
0222 of_detach_node() to detach the nodes from the live device tree.
0223
0224 To detach a node, of_detach_node() either updates the child pointer of given
0225 node's parent to its sibling or attaches the previous sibling to the given
0226 node's sibling, as appropriate. That is it :)